Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to include files.uploadV2 #1548

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

srajiang
Copy link
Member

Summary

Adds docs for files.uploadV2 wrapper method.

Requirements (place an x in each [ ])

@srajiang srajiang added the docs M-T: Documentation work only label Oct 25, 2022
@srajiang srajiang self-assigned this Oct 25, 2022
@seratch seratch added this to the web-api@6.8.0 milestone Oct 25, 2022
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srajiang Once the version error is fixed, all look good to me

@@ -448,15 +448,77 @@ retrying the API call. If you'd like to opt out of that behavior, set the `rejec
---

### Upload a file
As of @slack/web-api v2.8.0, we have introduced a modified way to upload files.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As of @slack/web-api v2.8.0, we have introduced a modified way to upload files.
As of @slack/web-api v6.8.0, we have introduced a modified way to upload files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, thanks for the catch! I've fixed it.

@srajiang srajiang force-pushed the sjiang-add-files-upload-v2-docs branch from 77e1150 to b105e71 Compare October 25, 2022 03:10
@seratch
Copy link
Member

seratch commented Oct 25, 2022

Thanks, this is now perfect ✅ Let's merge this PR once we ship the version!

@hello-ashleyintech
Copy link
Contributor

6.8.0 has been released: https://github.com/slackapi/node-slack-sdk/releases/tag/%40slack%2Fweb-api%406.8.0 will merge this PR in now!

@hello-ashleyintech
Copy link
Contributor

actually, it looks like I don't have admin rights and can't get past the 12.x check hanging 😬 will get someone with admin rights to merge this!
Screen Shot 2022-11-08 at 3 15 58 PM

@srajiang srajiang merged commit 85bf475 into main Nov 8, 2022
@srajiang srajiang deleted the sjiang-add-files-upload-v2-docs branch September 8, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants